-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: extract storages into sub crates #6981
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
mergify
bot
added
the
pr-refactor
this PR changes the code base without new features or bugfix
label
Aug 4, 2022
dantengsky
changed the title
refactor: split query
refactor: extract storages into sub crates
Aug 4, 2022
PsiACE
approved these changes
Aug 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Xuanwo
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
subtask of issue
All the refactoring work except explicitly noted, are pure renaming/moving things, no API/Implementation changed.
extract storages crates from crate
databend-query
new crates extracted:
common-storages-hive
(common/storages/hive)hive
catalog, tablescommon-storages-fuse
(common/storages/fuse)fuse
tablecommon-storages-index
(common/storages/index)min/max index, bloom filter index
common-storages-preludes
(common/storages/preludes)github
,memory
,null
,random
,view
information_schema
system
tables exceptcluster
stage
, andresult
are kept left in cratedatabend-query
, there are some unresolved dependency issues.other extracted crates:
other crates extracted "on-demand"
common-storages-util
(common/storages/preludes)Retry
trait and its default implStorageContext
better name?
common-pipeline-core
(common/pipeline/core)former
common-pipeline
common-pipeline-sinks
(common/pipeline/sink)common-pipeline-sources
(common/pipeline/sources)decoupled from
QueryContext
, use traitTableContext
insteadcommon-pipeline-transforms
(common/pipeline/transforms)base types, and part of the transforms that table engine impls needed
common-legacy-parser
(common/legacy-parser)the expression parser extracted from the legacy parser
about unit tests:
unit tests(tests/it/*) depends concrete type(especially the QueryContext), are not migratable yet
Fixes #issue