Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(expr): allow function to return runtime error #6662

Merged
merged 2 commits into from
Jul 17, 2022
Merged

feat(expr): allow function to return runtime error #6662

merged 2 commits into from
Jul 17, 2022

Conversation

andylokandy
Copy link
Collaborator

@andylokandy andylokandy commented Jul 17, 2022 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  • allow function to return runtime error
  • Column::index() returns Option instead of panic
  • test throwing error in get(Array(T0), Int16) :: T0

Tracked in #6547

@vercel
Copy link

vercel bot commented Jul 17, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Jul 17, 2022 at 9:48AM (UTC)

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Jul 17, 2022
@andylokandy andylokandy requested review from leiysky and sundy-li July 17, 2022 07:38
@andylokandy andylokandy mentioned this pull request Jul 17, 2022
Closed
33 tasks
Xuanwo
Xuanwo approved these changes Jul 17, 2022
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make clippy happy

@mergify mergify bot merged commit 4dff5ec into databendlabs:main Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@sundy-li sundy-li sundy-li left review comments

@leiysky leiysky leiysky approved these changes

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andylokandy @sundy-li @Xuanwo @leiysky