Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logictest): reset clickhouse sqlalchemy engine for each testfile. #6593

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented Jul 13, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

in the patched clickhouse-sqlalchemy client carry the settings applied.
need to reset for a new test file.

Fixes #issue

#6576 (comment)

@vercel
Copy link

vercel bot commented Jul 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Jul 13, 2022 at 3:20AM (UTC)

@mergify mergify bot added the pr-bugfix this PR patches a bug in codebase label Jul 13, 2022
@youngsofun youngsofun requested a review from ZeaLoVe July 13, 2022 03:24
@mergify mergify bot merged commit 5dc43ec into databendlabs:main Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants