Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: split common-users #6561

Merged
merged 5 commits into from
Jul 11, 2022
Merged

refactor: split common-users #6561

merged 5 commits into from
Jul 11, 2022

Conversation

PsiACE
Copy link
Member

@PsiACE PsiACE commented Jul 11, 2022 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

After this split:

  • query/users will be available as a common crate named common-users
  • refactor, replace query/users with common-users
    • users/auth/auth_mgr -> query/auth, because of QueryContext

Related #6180

@vercel
Copy link

vercel bot commented Jul 11, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Jul 11, 2022 at 4:21AM (UTC)

@mergify mergify bot added the pr-refactor this PR changes the code base without new features or bugfix label Jul 11, 2022
@Xuanwo
Copy link
Member

Xuanwo commented Jul 11, 2022

How about moving user-related structs out of meta-types?

@PsiACE
Copy link
Member Author

PsiACE commented Jul 11, 2022

How about moving user-related structs out of meta-types?

I will investigate it after replacing query/users.

@PsiACE PsiACE marked this pull request as ready for review July 11, 2022 04:22
@PsiACE PsiACE requested review from junnplus and drmingdrmer July 11, 2022 08:40
drmingdrmer
drmingdrmer approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me!

@BohuTANG
Copy link
Member

looks great to me!

@BohuTANG BohuTANG merged commit ebc5ebd into databendlabs:main Jul 11, 2022
@PsiACE PsiACE deleted the refactor-users branch July 13, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drmingdrmer drmingdrmer drmingdrmer approved these changes

@junnplus junnplus Awaiting requested review from junnplus

Assignees
No one assigned
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PsiACE @Xuanwo @BohuTANG @drmingdrmer