Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): fix certificates dependencies #6136

Merged
merged 4 commits into from
Jun 22, 2022

Conversation

wfxr
Copy link
Contributor

@wfxr wfxr commented Jun 22, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Add missing certificates dependencies to Dockerfile

Changelog

  • Bug Fix

Related Issues

Fixes #6134

@vercel
Copy link

vercel bot commented Jun 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
databend ✅ Ready (Inspect) Visit Preview Jun 22, 2022 at 5:23AM (UTC)

@mergify
Copy link
Contributor

mergify bot commented Jun 22, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the pr-bugfix this PR patches a bug in codebase label Jun 22, 2022
@PsiACE PsiACE requested review from Xuanwo and everpcpc June 22, 2022 04:41
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, requiring @everpcpc for extra confirmation.

@Xuanwo
Copy link
Member

Xuanwo commented Jun 22, 2022

@wfxr Happy to see you again!

@wfxr
Copy link
Contributor Author

wfxr commented Jun 22, 2022

@Xuanwo Happy to see you too :)

@Xuanwo
Copy link
Member

Xuanwo commented Jun 22, 2022

This PR will get merged automatically after all required checks are passed.

@mergify mergify bot merged commit 2d5352b into databendlabs:main Jun 22, 2022
@wfxr wfxr deleted the fix/certificates-error branch June 22, 2022 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-review pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: creating database using GITHUB engine always fails
4 participants