Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(insert): server panic when exceeds max active sessions #5928

Merged
merged 2 commits into from
Jun 13, 2022

Conversation

fkuner
Copy link
Contributor

@fkuner fkuner commented Jun 13, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  1. bug fix: delete processing entry
  2. bug fix: return err when server panic

cc @BohuTANG

Changelog

  • Bug Fix

Related Issues

Fixes #5844

#5567 (comment)

@vercel
Copy link

vercel bot commented Jun 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Jun 13, 2022 at 2:32AM (UTC)

@mergify
Copy link
Contributor

mergify bot commented Jun 13, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the pr-bugfix this PR patches a bug in codebase label Jun 13, 2022
@fkuner fkuner requested review from sundy-li and b41sh June 13, 2022 02:30
@fkuner fkuner changed the title fix server panic when exceeds max active sessions fix(insert): server panic when exceeds max active sessions Jun 13, 2022
@fkuner fkuner marked this pull request as ready for review June 13, 2022 03:07
@b41sh
Copy link
Member

b41sh commented Jun 13, 2022

Almost ok for me, it's better to add some unit tests.

@fkuner
Copy link
Contributor Author

fkuner commented Jun 13, 2022

Almost ok for me, it's better to add some unit tests.

Good idea. Now the client can control the enable_async_insert, so we can add more stateless-test about async-insert.

@fkuner
Copy link
Contributor Author

fkuner commented Jun 13, 2022

I will add a new pr to cover all test cases about async-insert.

@BohuTANG BohuTANG merged commit 51ead48 into databendlabs:main Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-review pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: server panic when exceed max_active_sessions in async insert mode
5 participants