feature(planner): Migrate DROP USER statement to new planner #5813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
leiysky
approved these changes
Jun 7, 2022
BohuTANG
reviewed
Jun 7, 2022
| DROP USER 'test-l'@'localhost'; | ||
| DROP USER IF EXISTS 'test-l'@'localhost'; | ||
| DROP USER IF EXISTS 'test-l'@'localhost'; | ||
| DROP USER IF EXISTS 'test-l'@'localhost'; |
There was a problem hiding this comment.
It would be better to teardown with set enable_planner_v2=0;
There was a problem hiding this comment.
We has already migrate create user to planner v2. And in 05_0007_ddl_drop_user.sql the test is enable_planner_v2=0. I think if we migrate all statement to planner v2 we can delete old test.
12 tasks
|
Maybe we can merge this pr?@BohuTANG |
|
Conflicting files :/ |
TCeason
force-pushed
the
ISSUE-5777/drop_user_v2
branch
from
64085a5 to
315abc4
Compare
Already resolve it. Just wait ci pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Migrate drop user to new planner
Changelog
Related Issues
#5777