Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parser): add span for expression #5309

Merged
merged 2 commits into from
May 11, 2022
Merged

Conversation

andylokandy
Copy link
Collaborator

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  • add source span information to the expr ast, which can be used to display type error in the type checker.

Changelog

  • New Feature

@vercel
Copy link

vercel bot commented May 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) May 11, 2022 at 7:31PM (UTC)

@andylokandy andylokandy requested review from leiysky and sundy-li and removed request for leiysky May 11, 2022 19:09
@mergify
Copy link
Contributor

mergify bot commented May 11, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label May 11, 2022
@andylokandy andylokandy requested a review from BohuTANG as a code owner May 11, 2022 19:31
@andylokandy andylokandy requested review from leiysky and xudong963 and removed request for BohuTANG May 11, 2022 19:34
@BohuTANG BohuTANG merged commit 5251ba2 into databendlabs:main May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-review pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants