Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a helper ExpressionEvaluator to simplify expression evaluation #5108

Merged
merged 5 commits into from
Apr 30, 2022

Conversation

leiysky
Copy link
Contributor

@leiysky leiysky commented Apr 29, 2022

Signed-off-by: leiysky leiysky@outlook.com

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Introduce a helper ExpressionEvaluator which evaluates scalar expression in a recursive fashion.

Compare to ExpressionExecutor, ExpressionEvaluator doesn't rely on DataSchema, and won't produce intermidiate result. It's useful when you want to evaluate an expression on the fly.

Changelog

  • New Feature

Related Issues

Fixes #5105

Signed-off-by: leiysky <leiysky@outlook.com>
@leiysky leiysky added C-feature Category: feature need-review labels Apr 29, 2022
@leiysky leiysky requested review from sundy-li and zhang2014 April 29, 2022 15:40
@leiysky leiysky requested a review from BohuTANG as a code owner April 29, 2022 15:40
@vercel
Copy link

vercel bot commented Apr 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
databend ✅ Ready (Inspect) Visit Preview Apr 30, 2022 at 5:49AM (UTC)

@mergify
Copy link
Contributor

mergify bot commented Apr 29, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Apr 29, 2022
leiysky added 2 commits April 30, 2022 01:22
Signed-off-by: leiysky <leiysky@outlook.com>
Signed-off-by: leiysky <leiysky@outlook.com>
Signed-off-by: leiysky <leiysky@outlook.com>
@mergify mergify bot merged commit 83f5f06 into databendlabs:main Apr 30, 2022
@leiysky leiysky deleted the expression-executor branch April 30, 2022 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category: feature need-review pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce a helper to evaluate scalar expression
4 participants