-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a helper ExpressionEvaluator to simplify expression evaluation #5108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: leiysky <leiysky@outlook.com>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
mergify
bot
added
the
pr-feature
this PR introduces a new feature to the codebase
label
Apr 29, 2022
Signed-off-by: leiysky <leiysky@outlook.com>
Signed-off-by: leiysky <leiysky@outlook.com>
BohuTANG
reviewed
Apr 29, 2022
sundy-li
reviewed
Apr 29, 2022
zhang2014
reviewed
Apr 30, 2022
Signed-off-by: leiysky <leiysky@outlook.com>
sundy-li
approved these changes
Apr 30, 2022
BohuTANG
approved these changes
Apr 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: leiysky leiysky@outlook.com
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Introduce a helper
ExpressionEvaluator
which evaluates scalar expression in a recursive fashion.Compare to
ExpressionExecutor
,ExpressionEvaluator
doesn't rely onDataSchema
, and won't produce intermidiate result. It's useful when you want to evaluate an expression on the fly.Changelog
Related Issues
Fixes #5105