fix: clickhouse worker hang when interpreter fail to execute #5091

chowc · 2022-04-28T12:04:40Z

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

fix clickhouse interactive_worker hang and does not send response to client.

set cancel_clone to Relaxed when interpreter.execute return a error;
make process_select_query return Err when things go wrong rather than always return Ok(rx)

Fixes #5005

vercel · 2022-04-28T12:04:44Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Updated
databend	⬜️ Ignored (Inspect)		Apr 29, 2022 at 2:39AM (UTC)

mergify · 2022-04-28T12:05:13Z

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

databend-bot added the need-review label Apr 28, 2022

mergify bot added the pr-bugfix this PR patches a bug in codebase label Apr 28, 2022

fix: clickhouse worker hang when interpreter fail to execute

c2e59a4

chowc force-pushed the fix-clickhouse-hang branch from 72bfbef to c2e59a4 Compare April 29, 2022 02:39

chowc marked this pull request as ready for review April 29, 2022 06:30

chowc requested a review from BohuTANG as a code owner April 29, 2022 06:30

BohuTANG requested a review from zhang2014 April 29, 2022 06:38

zhang2014 approved these changes Apr 29, 2022

View reviewed changes

zhang2014 merged commit f82d66d into databendlabs:main Apr 29, 2022