Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser): allow to omit semicolon #5058

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

andylokandy
Copy link
Collaborator

@andylokandy andylokandy commented Apr 26, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  • make the semicolon on the statements optional

Changelog

  • Bug Fix
  • Improvement

Related Issues

closes #5044

@vercel
Copy link

vercel bot commented Apr 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Apr 26, 2022 at 6:37AM (UTC)

@mergify
Copy link
Contributor

mergify bot commented Apr 26, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added pr-bugfix this PR patches a bug in codebase pr-improvement labels Apr 26, 2022
@andylokandy andylokandy requested review from leiysky and sundy-li April 26, 2022 06:38
@leiysky
Copy link
Contributor

leiysky commented Apr 26, 2022

By the way, I'm still curious about the root cause...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-review pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: select can't work in new parser
4 participants