Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement azblob support #5025

Merged
merged 3 commits into from
Apr 24, 2022
Merged

feat: Implement azblob support #5025

merged 3 commits into from
Apr 24, 2022

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Apr 24, 2022 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

This PR will add azblob support

Fix #4738

Start an azblob container:

podman run -p 10000:10000 mcr.microsoft.com/azure-storage/azurite azurite-blob --blobHost 0.0.0.0 --blobPort 10000

Run databend-query:

STORAGE_TYPE=azblob STORAGE_AZBLOB_ENDPOINT_URL=http://127.0.0.1:10000/devstoreaccount1 STORAGE_AZBLOB_CONTAINER=mycontainer STORAGE_AZBLOB_ACCOUNT_NAME=devstoreaccount1 STORAGE_AZBLOB_ACCOUNT_KEY=Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw== ./target/debug/databend-query

Changelog

  • New Feature

Xuanwo added 2 commits April 24, 2022 15:30
@Xuanwo
Implement azblob support
87817f1 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Fix test
3212c34 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested a review from BohuTANG as a code owner April 24, 2022 07:55
@vercel
Copy link

vercel bot commented Apr 24, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Apr 24, 2022 at 9:14AM (UTC)

@mergify
Copy link
Contributor

mergify bot commented Apr 24, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Apr 24, 2022
@Xuanwo Xuanwo assigned sundy-li and dantengsky and unassigned sundy-li and dantengsky Apr 24, 2022
@Xuanwo Xuanwo requested review from sundy-li and dantengsky April 24, 2022 08:30
@Xuanwo
Copy link
Member Author

Xuanwo commented Apr 24, 2022

Sorry for the wrong assignment. I'm requesting for review.

dantengsky
dantengsky approved these changes Apr 24, 2022
View reviewed changes
Copy link
Member

@dantengsky dantengsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xuanwo
Copy link
Member Author

Xuanwo commented Apr 24, 2022 

The failure tests:
    /Users/runner/work/databend/databend/tests/suites/0_stateless/09_fuse_engine/09_0008_fuse_optimize_table.sql

Wired. Seems a flasky test.

@mergify mergify bot merged commit df4ff7d into databendlabs:main Apr 24, 2022
@Xuanwo Xuanwo deleted the azblob branch April 24, 2022 12:06
@BohuTANG BohuTANG mentioned this pull request May 12, 2022
Closed
55 tasks
@Xuanwo Xuanwo added this to the v0.8 milestone May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantengsky dantengsky dantengsky approved these changes

@BohuTANG BohuTANG BohuTANG approved these changes

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
need-review pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
v0.8
Development

Successfully merging this pull request may close these issues.

Support use azblob as storage backend
5 participants
@Xuanwo @BohuTANG @dantengsky @sundy-li @databend-bot