Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(parser): add select statement #4941

Merged
merged 11 commits into from
Apr 20, 2022
Merged

feat(parser): add select statement #4941

merged 11 commits into from
Apr 20, 2022

Conversation

andylokandy
Copy link
Collaborator

@andylokandy andylokandy commented Apr 19, 2022 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  • Implement select statements with trivial joins.
  • Refresh AST and parser for type name
  • Add various DDL statements

Changelog

  • New Feature

Related Issues

@vercel
Copy link

vercel bot commented Apr 19, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
databend ✅ Ready (Inspect) Visit Preview Apr 20, 2022 at 8:45AM (UTC)

@mergify
Copy link
Contributor

mergify bot commented Apr 19, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Apr 19, 2022
@andylokandy andylokandy added the A-planner Area: planner/optimizer label Apr 19, 2022
@leiysky leiysky self-requested a review April 19, 2022 10:06
@leiysky
Copy link
Contributor

leiysky commented Apr 19, 2022

Rest LGTM.

@BohuTANG
Copy link
Member

'make lint' locally will make the check CI happy :)

@andylokandy
Copy link
Collaborator Author

'make lint' locally will make the check CI happy :)

But it all-checks on my laptop

@BohuTANG
Copy link
Member

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Apr 20, 2022

update

✅ Branch has been successfully updated

@BohuTANG
Copy link
Member

BohuTANG commented Apr 20, 2022 •
edited
Loading

CI failures with cargo clippy --tests -- -D warnings:
https://github.com/datafuselabs/databend/runs/6088060806?check_suite_focus=true#step:3:962

@BohuTANG
Copy link
Member

Same error on my local.

@sundy-li
Copy link
Member

Maybe some files are not commited.

@andylokandy
Copy link
Collaborator Author

I've force-pushed again, let's wait and see.

@andylokandy
Copy link
Collaborator Author

Same error on my local.

Confirmed after re-pulling. Seems like the git has silently merged upstream changes without modifying the local file.

@andylokandy andylokandy reopened this Apr 20, 2022
@BohuTANG
Copy link
Member

Ci failure:
image

CI error log is at:
https://github.com/datafuselabs/databend/runs/6089539318?check_suite_focus=true#step:3:965

@BohuTANG
Copy link
Member

BTW, if a CI is failure, we can check the detail logs:
image

@leiysky leiysky merged commit 0f31123 into databendlabs:main Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leiysky leiysky leiysky left review comments

@sundy-li sundy-li sundy-li approved these changes

Assignees
No one assigned
Labels
A-planner Area: planner/optimizer need-review pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andylokandy @leiysky @BohuTANG @sundy-li @databend-bot