-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve: pass parameter from query to functions #4805
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/databend/databend/7ESMFpdBcSbhtyRLv8Y5ZkugzWRh [Deployment for c5ddb3e canceled] |
Thanks for the contribution! Please review the labels and make any necessary changes. |
Signed-off-by: Veeupup <code@tanweime.com>
Signed-off-by: Veeupup <code@tanweime.com>
Signed-off-by: Veeupup <code@tanweime.com>
Signed-off-by: Veeupup <code@tanweime.com>
It better to name |
Signed-off-by: Veeupup code@tanweime.com
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
this pr is for timezone support subtask(part of #4651 ):
to support different timezone, we need to pass
timezone
setting from session to function. To be specific, we need to gettimezone
in session settings(TODO) to pass toFunctionContext
to make date function work correctly.code change:
a lot of function need to add a parameter
QueryContext
so so many files need to be changed.and we will finally construct
FunctionContext
whenExpressionExecutor
creating.Changelog
Related Issues
Fixes x