Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: pass parameter from query to functions #4805

Merged
merged 6 commits into from
Apr 13, 2022

Conversation

Veeupup
Copy link
Contributor

@Veeupup Veeupup commented Apr 12, 2022

Signed-off-by: Veeupup code@tanweime.com

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

this pr is for timezone support subtask(part of #4651 ):
to support different timezone, we need to pass timezone setting from session to function. To be specific, we need to get timezone in session settings(TODO) to pass to FunctionContext to make date function work correctly.

code change:
a lot of function need to add a parameter QueryContext so so many files need to be changed.
and we will finally construct FunctionContext when ExpressionExecutor creating.

Changelog

  • Improvement

Related Issues

Fixes x

@vercel
Copy link

vercel bot commented Apr 12, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/7ESMFpdBcSbhtyRLv8Y5ZkugzWRh
✅ Preview: https://databend-git-fork-veeupup-timezone-databend.vercel.app

[Deployment for c5ddb3e canceled]

@mergify
Copy link
Contributor

mergify bot commented Apr 12, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Apr 12, 2022
Veeupup added 3 commits April 13, 2022 11:49
Signed-off-by: Veeupup <code@tanweime.com>
Signed-off-by: Veeupup <code@tanweime.com>
Signed-off-by: Veeupup <code@tanweime.com>
Signed-off-by: Veeupup <code@tanweime.com>
@Veeupup Veeupup changed the title feat: support timezone improve: pass parameter from query to functions Apr 13, 2022
@Veeupup Veeupup marked this pull request as ready for review April 13, 2022 09:00
@Veeupup Veeupup requested a review from BohuTANG as a code owner April 13, 2022 09:00
@Veeupup Veeupup requested review from b41sh and sundy-li April 13, 2022 09:00
@BohuTANG BohuTANG merged commit 69dee28 into databendlabs:main Apr 13, 2022
@BohuTANG
Copy link
Member

It better to name FunctionOption than FunctionContext :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-review pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants