-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISSUE-4262: prohibits using reserved table option in create table statement. #4632
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/databend/databend/B4D1SNghysUsLGRxeikXL7RHTYR9 [Deployment for 8b29e62 canceled] |
Thanks for the contribution! Please review the labels and make any necessary changes. |
Got a problem in the stateless test, Seems there are some flaws in the arrangement of snapshot versioning, digging into it. PR will be marked as ready after the CI passed. |
- unify dev stateless test with the corresponding CI tests - ci-run-tests-embedded.sh does not enable table cache which is a better setting to discovery more potential flaws
- no longer use table option key SNAPSHOT_VER - infer the version of snapshot from snapshot location Only in the bootstrap phase, i.e. the version of snapshot that comes directly from TableInfo is deduced in this way. For the versions of history snapshots, the numeric values that kept in meta data file are used. Later, when zero-copy clone is implemented seriously, the above inconsistency should disappear.
@BohuTANG PTAL: besides issue #4624 that this PR is trying to address:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
DATABASE_ID
andSNAPSHOT_VER
are now reserved fuse table option keysMISC:
unify dev stateless test with the corresponding CI tests
ci-run-tests-embedded.sh does not enable table cache
which is a better setting to discover more potential flaws
no longer use table option key SNAPSHOT_VER
infer the version of snapshot from snapshot location
Only in the bootstrap phase, i.e. the version of snapshot that comes
directly from TableInfo is deduced in this way.
For the versions of history snapshots, the numeric values that kept
in meta data file are used.
Later, when zero-copy clone is implemented seriously, the above inconsistency
should disappear.
Changelog
Related Issues
Fixes #4624
Test Plan
Unit Tests
Stateless Tests