Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SESSIONS-3933: Refine function name [PATCH-2] #4021

Merged
merged 1 commit into from
Jan 29, 2022

Conversation

BohuTANG
Copy link
Member

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR:

  1. Rename *MgrApi to *Api in management
  2. Rename context_shared to query_context_shared

Changelog

  • Improvement

Related Issues

PATCH-2 of #3933

Test Plan

Unit Tests

Stateless Tests

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@vercel
Copy link

vercel bot commented Jan 29, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/Bpr4bJc3gLK7ErvXZHLegr8phgng
✅ Preview: Canceled

Copy link
Member

@zhang2014 zhang2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me.

Copy link
Member

@PsiACE PsiACE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #4021 (a9872b3) into main (ffd5026) will increase coverage by 0%.
The diff coverage is 57%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4021   +/-   ##
=====================================
  Coverage     57%     57%           
=====================================
  Files        817     817           
  Lines      43406   43402    -4     
=====================================
- Hits       24787   24786    -1     
+ Misses     18619   18616    -3     
Impacted Files Coverage Δ
common/management/src/role/role_mgr.rs 77% <ø> (ø)
common/management/src/stage/stage_mgr.rs 94% <ø> (ø)
common/management/src/udf/udf_mgr.rs 88% <ø> (ø)
common/management/src/user/user_mgr.rs 94% <ø> (ø)
query/src/users/user_api.rs 77% <57%> (+5%) ⬆️
common/containers/src/pool.rs 79% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffd5026...a9872b3. Read the comment docs.

@mergify mergify bot merged commit b9070da into databendlabs:main Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants