-
Notifications
You must be signed in to change notification settings - Fork 761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[string performence improvement] #3288
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/databend/databend/FPa2TDzJkuyXDr1nnRJsAUtMQxpX [Deployment for 4046f6b canceled] |
Codecov Report
@@ Coverage Diff @@
## main #3288 +/- ##
======================================
Coverage 65% 65%
======================================
Files 705 710 +5
Lines 38272 38634 +362
======================================
+ Hits 24928 25183 +255
- Misses 13344 13451 +107
Continue to review full report at Codecov.
|
Is the performance in debug mode or release mode? |
sorry, I test it in debug mode ... I try make it in release mode later |
Thanks for the contribution! Please review the labels and make any necessary changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
And I think it's time to add transfrom_from_primitive
function.
Wait for another reviewer approval |
I hereby agree to the terms of the CLA available at: https://databend.rs/policies/cla/
Summary
improve string function performance
before:
![image](https://user-images.githubusercontent.com/26339429/145218617-dbd50786-d5fa-49bd-b178-480fa0a66633.png)
now:
![image](https://user-images.githubusercontent.com/26339429/145218659-2f0bfbc5-6bcd-420a-a6d7-e6f3ebeff363.png)
Changelog
Related Issues
Fixes #3259
Test Plan
Unit Tests
Stateless Tests