Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy command to load local file into table [patch-1] #2682

Closed
wants to merge 7 commits into from

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Nov 7, 2021

I hereby agree to the terms of the CLA available at: https://databend.rs/policies/cla/

Summary

Summary about this PR

Changelog

  • New Feature

Related Issues

Related #2627

Test Plan

Unit Tests

Stateless Tests

@databend-bot databend-bot added the pr-feature this PR introduces a new feature to the codebase label Nov 7, 2021
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@sundy-li sundy-li changed the title Copy command to load local file into table Copy command to load local file into table [patch-1] Nov 8, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2021

Codecov Report

Merging #2682 (2e80e1b) into main (510435e) will decrease coverage by 0%.
The diff coverage is 73%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2682   +/-   ##
=====================================
- Coverage     69%     69%   -1%     
=====================================
  Files        619     619           
  Lines      33398   33457   +59     
=====================================
+ Hits       23163   23194   +31     
- Misses     10235   10263   +28     
Impacted Files Coverage Δ
common/planners/src/plan_insert_into.rs 59% <ø> (ø)
query/src/sql/plan_parser.rs 73% <18%> (-2%) ⬇️
query/src/sql/sql_parser_test.rs 83% <85%> (+<1%) ⬆️
query/src/sql/sql_parser.rs 80% <94%> (+<1%) ⬆️
query/src/configs/config_storage.rs 87% <100%> (ø)
...y/src/datasources/table/fuse/index/min_max_test.rs 92% <100%> (ø)
...ry/src/datasources/table/fuse/io/block_appender.rs 95% <100%> (+<1%) ⬆️
...c/datasources/table/fuse/io/block_appender_test.rs 90% <100%> (ø)
...y/src/datasources/table/fuse/table_test_fixture.rs 93% <100%> (+<1%) ⬆️
...tasources/table/fuse/util/statistic_helper_test.rs 97% <100%> (+<1%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 510435e...2e80e1b. Read the comment docs.

@@ -91,6 +91,8 @@ sha2 = "0.9.8"
structopt = "0.3"
structopt-toml = "0.5.0"
threadpool = "1.8.1"

tokio = { version = "1.13.0", features = ["fs"] }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to use common/base/runtime?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A mistake made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-review pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants