Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implemented a new sql explain analyze graphical #16543

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Maricaya
Copy link

@Maricaya Maricaya commented Sep 29, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Implemented a new explain analyze graphical command to visualize SQL performance analysis.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Sep 29, 2024
@Maricaya Maricaya marked this pull request as ready for review September 29, 2024 06:30
@Maricaya
Copy link
Author

@zhang2014 The contributor is from the Open Source Promotion Plan 2024.
I'm so sorry to have to close the previous PR due to my missteps. I'd be really grateful if you could take a look at this one instead.

@dqhl76
Copy link
Collaborator

dqhl76 commented Sep 29, 2024

Hi @Maricaya, it seems the test failed because we need to run cargo +nightly fmt to ensure the code is well-formatted and clean. When you have a moment, you might want to run make lint to apply all the linting checks. Thank you!


let line_split_result: Vec<&str> = json_string.lines().collect();
let formatted_block = StringType::from_data(line_split_result);
blocks.push(DataBlock::new_from_columns(vec![formatted_block]));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
blocks.push(DataBlock::new_from_columns(vec![formatted_block]));
vec![DataBlock::new_from_columns(vec![formatted_block])]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants