Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(query): DATE_ADD Functions to support week as a unit #16530

Merged
merged 1 commit into from
Sep 27, 2024
Merged

feat(query): DATE_ADD Functions to support week as a unit #16530

merged 1 commit into from
Sep 27, 2024
+46 −0

Conversation

TracyZYJ
Copy link
Contributor

@TracyZYJ TracyZYJ commented Sep 26, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

date_add support week as unit.

SELECT DATE_ADD('week', 1, TODAY())=DATE_ADD('day', 7, TODAY())

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Sep 26, 2024
@TCeason
Copy link
Collaborator

TCeason commented Sep 26, 2024

LGTM. Please review this pr @b41sh

@sundy-li sundy-li added this pull request to the merge queue Sep 27, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Sep 27, 2024
@BohuTANG BohuTANG merged commit 6f10276 into databendlabs:main Sep 27, 2024
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li approved these changes

@TCeason TCeason TCeason approved these changes

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Date Functions to support week as a unit
4 participants
@TracyZYJ @TCeason @sundy-li @BohuTANG