Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: unify path of write segment #16517

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

SkyFan2002
Copy link
Member

@SkyFan2002 SkyFan2002 commented Sep 25, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  1. remove duplicated SegmentWriter, SegmentsIO::write_segment(), use Segment::write_meta() and Segment::write_meta_through_cache() should be ok.
  2. remove impl CachedObject<CompactSegmentInfo> for CompactSegmentInfo

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - just refactor

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Sep 25, 2024
@SkyFan2002 SkyFan2002 marked this pull request as ready for review September 25, 2024 07:00
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 25, 2024
@dosubot dosubot bot added the A-storage Area: databend storage label Sep 25, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 25, 2024
@dantengsky dantengsky added this pull request to the merge queue Sep 25, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Sep 25, 2024
@BohuTANG BohuTANG merged commit a402d6c into databendlabs:main Sep 25, 2024
95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-storage Area: databend storage lgtm This PR has been approved by a maintainer pr-refactor this PR changes the code base without new features or bugfix size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants