Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplify SchemaApi::truncate_table() #16506

Merged
merged 4 commits into from
Sep 25, 2024

Commits on Sep 25, 2024

  1. refactor: SchemaApi::list_tables() should specify db-id instead of db…

    …-name
    
    - Change list_tables() to accept db_id instead of db_name for better precision
    - Modify return type from TableInfo to (table_name, table_id,
      SeqV<table_meta>).
      Because some info in TableInfo can not be provided by SchemaApi
    drmingdrmer committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c4a6491 View commit details
    Browse the repository at this point in the history
  2. refactor: when SchemaApi::truncate_table(), no need to assert table seq

    truncate_table() first lists all copied files belonging to a table,
    then deletes them in small chunks. The delete operations assert that
    the seq of each file does not change.
    
    With this approach, there is no need to assert that the seq of the
    containing table does not change.
    drmingdrmer committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    e43942d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a9048ef View commit details
    Browse the repository at this point in the history
  4. chore: fixup lint

    drmingdrmer committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    688f3a0 View commit details
    Browse the repository at this point in the history