Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fast path for cross join to optimize tpcds q23 (~50x) #16504

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

xudong963
Copy link
Member

@xudong963 xudong963 commented Sep 24, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Note: tpcds 1GB. Local machine M1 mac, 8c 32GB

This PR adds a fast path for cross join when build side only has a row, which matches tpcds q23's pattern(build side is from a max/sum agg).

By the fast path, we can avoid memory reallocation. Then reduce cache miss and improve the ability of SIMD for next operators.

Before: 26s
image

Now: 0.4s
img_v3_02f0_b8e12fc1-0406-40c7-a18b-cd80033e426g

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 24, 2024
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Sep 24, 2024
@dosubot dosubot bot added A-query Area: databend query C-performance Category: Performance labels Sep 24, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 24, 2024
@sundy-li sundy-li added this pull request to the merge queue Sep 24, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Sep 24, 2024
@BohuTANG BohuTANG merged commit 8e79625 into databendlabs:main Sep 24, 2024
111 checks passed
@xudong963 xudong963 deleted the q23 branch September 25, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-query Area: databend query C-performance Category: Performance lgtm This PR has been approved by a maintainer pr-feature this PR introduces a new feature to the codebase size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants