feat: add fast path for cross join to optimize tpcds q23 (~50x) #16504
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Note: tpcds 1GB. Local machine M1 mac, 8c 32GB
This PR adds a fast path for cross join when build side only has a row, which matches tpcds q23's pattern(build side is from a max/sum agg).
By the fast path, we can avoid memory reallocation. Then reduce cache miss and improve the ability of SIMD for next operators.
Before: 26s
Now: 0.4s
Tests
Type of change
This change is