Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storage): hook recluster avoid scan all segments #16498

Merged
merged 7 commits into from
Sep 25, 2024

Conversation

zhyass
Copy link
Member

@zhyass zhyass commented Sep 23, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  1. avoid scan all segments when do hook recluster
  2. recluster will compact the small block and segments.
  3. insert will trigger compact and recluster.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 23, 2024
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Sep 23, 2024
@dosubot dosubot bot added the A-storage Area: databend storage label Sep 23, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Sep 23, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 23, 2024
@dantengsky dantengsky added this pull request to the merge queue Sep 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 23, 2024
@zhyass zhyass marked this pull request as draft September 23, 2024 15:20
@zhyass zhyass marked this pull request as ready for review September 23, 2024 15:40
@zhyass
Copy link
Member Author

zhyass commented Sep 23, 2024

The new commit, PTAL @dantengsky
260874a

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Sep 23, 2024
@zhyass zhyass force-pushed the feature_fix branch 2 times, most recently from 2d36f90 to 04112b7 Compare September 24, 2024 02:58
Merged via the queue into databendlabs:main with commit e665183 Sep 25, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-storage Area: databend storage lgtm This PR has been approved by a maintainer pr-chore this PR only has small changes that no need to record, like coding styles. size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants