-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump arrow2 #1575
bump arrow2 #1575
Conversation
Thanks for the contribution! Please review the labels and make any necessary changes. |
@@ -15,7 +15,7 @@ simd = ["arrow/simd"] | |||
# Workspace dependencies | |||
|
|||
# Github dependencies | |||
arrow = { package = "arrow2", git="https://github.com/datafuse-extras/arrow2", rev = "647fddb" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not enough because the high-version library isn't compatible with old-version.
Need more modification.
Shouldn't the test be
i.e.
|
Yes, I made a mistake, the tests code should be But the ci in
got:
Can't reproduce it in my local mac, I will try to find a reproduce case to fix this. |
No worries. I also tried to reproduce it on a linux with both |
Codecov Report
@@ Coverage Diff @@
## master #1575 +/- ##
=======================================
Coverage 73% 73%
=======================================
Files 535 535
Lines 33020 33415 +395
=======================================
+ Hits 24284 24575 +291
- Misses 8736 8840 +104
Continue to review full report at Codecov.
|
CI Passed |
I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/
Summary
bump arrow2
Changelog
Related Issues
Fixes #1573
Test Plan
Unit Tests
Stateless Tests