Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump arrow2 #1575

Merged
merged 7 commits into from
Aug 24, 2021
Merged

bump arrow2 #1575

merged 7 commits into from
Aug 24, 2021

Conversation

sundy-li
Copy link
Member

I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/

Summary

bump arrow2

Changelog

  • Improvement

Related Issues

Fixes #1573

Test Plan

Unit Tests

Stateless Tests

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@@ -15,7 +15,7 @@ simd = ["arrow/simd"]
# Workspace dependencies

# Github dependencies
arrow = { package = "arrow2", git="https://github.com/datafuse-extras/arrow2", rev = "647fddb" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not enough because the high-version library isn't compatible with old-version.
Need more modification.

@jorgecarleitao
Copy link

Shouldn't the test be

#[test]
fn test_gt_u64_scalar() {
    let a = UInt64Array::from_slice(&[0,1,2]);
    let c = gt_scalar(&a, 0);
    assert_eq!(BooleanArray::from_slice(&[false, true, true]), c);
}

i.e.

0 > 0 = false
1 > 0 = true
2 > 0 = true

@sundy-li
Copy link
Member Author

sundy-li commented Aug 23, 2021

Shouldn't the test be

Yes, I made a mistake, the tests code should be gt_scalar(&a, 1).

But the ci in macos-latest is failed, test case :

select if(number>1, true, false) from numbers(3) order by number;

got:

false
false
false

Can't reproduce it in my local mac, I will try to find a reproduce case to fix this.

@jorgecarleitao
Copy link

No worries. I also tried to reproduce it on a linux with both simd and no simd but I am also unable to do so :/

@sundy-li sundy-li requested a review from zhyass August 24, 2021 08:29
@sundy-li sundy-li marked this pull request as ready for review August 24, 2021 08:29
@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2021

Codecov Report

Merging #1575 (3019005) into master (dbc8332) will increase coverage by 0%.
The diff coverage is 83%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #1575    +/-   ##
=======================================
  Coverage      73%     73%            
=======================================
  Files         535     535            
  Lines       33020   33415   +395     
=======================================
+ Hits        24284   24575   +291     
- Misses       8736    8840   +104     
Impacted Files Coverage Δ
common/datavalues/src/arrays/arithmetic.rs 26% <ø> (ø)
common/datavalues/src/arrays/ops/agg.rs 65% <0%> (ø)
common/datavalues/src/arrays/upstream_traits.rs 62% <0%> (ø)
store/src/data_part/appender.rs 95% <ø> (ø)
store/src/executor/action_handler.rs 58% <0%> (-1%) ⬇️
common/datavalues/src/arrays/comparison.rs 37% <100%> (ø)
common/datavalues/src/arrays/ops/if_test.rs 98% <100%> (+<1%) ⬆️
query/src/datasources/local/parquet_table.rs 69% <100%> (+<1%) ⬆️
store/src/data_part/appender_test.rs 95% <100%> (ø)
query/src/sql/parser/ast/mod.rs 15% <0%> (-3%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbc8332...3019005. Read the comment docs.

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot databend-bot merged commit 4772226 into master Aug 24, 2021
@databend-bot databend-bot deleted the sundy-li-patch-1 branch August 24, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The dependence arrow2 is old
6 participants