Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): Don't return empty credential while loading failed #15181

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Apr 8, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

OpenDAL currently returns an empty credential when COS loading fails—for instance, if there's an error with COS IAM. As a result, this triggers a Permission Denied error on the Databend side.

This PR modifies OpenDAL's behavior to return a retryable error instead, allowing OpenDAL to internally retry the request.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - OpenDAL related changes.

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Apr 8, 2024
Xuanwo added 2 commits April 8, 2024 12:07
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@BohuTANG BohuTANG merged commit 955b390 into databendlabs:main Apr 8, 2024
69 checks passed
@Xuanwo Xuanwo deleted the cos-hotfix branch April 8, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants