-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove dependency on parquet2: Part I #15158
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-refactor
this PR changes the code base without new features or bugfix
label
Apr 2, 2024
also in |
# Conflicts: # tests/sqllogictests/suites/base/13_parquet_rs/13_05_0003_ddl_alter_table_backward.test # tests/sqllogictests/suites/base/13_parquet_rs/13_05_0003_ddl_alter_table_forward.test # tests/sqllogictests/suites/base/13_parquet_rs/13_05_0028_ddl_alter_table_add_drop_column_backward.test # tests/sqllogictests/suites/base/13_parquet_rs/13_05_0028_ddl_alter_table_add_drop_column_forward.test
SkyFan2002
changed the title
refactor: remove dependency on parquet2
refactor: remove dependency on parquet2: Part I
Apr 7, 2024
sundy-li
approved these changes
Apr 7, 2024
b41sh
approved these changes
Apr 7, 2024
dantengsky
approved these changes
Apr 7, 2024
This was referenced Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
In #14268, the serialization and deserialization of data blocks (of fuse engine) have been migrated to parquet-rs. After sufficient verification, we believe the previous migration is reliable. This PR will completely remove the dependency on Parquet2.
In the previous PR, for caution, we retained the code for reading and writing data blocks using Parquet2. In this PR, we will remove this code, along with the compatibility tests between Parquet2 and parquet-rs.
Some components in our system still depend on Parquet2. They will be migrated to parquet-rs in this PR:
Still residual parquet2 after this PR:
Tests
Type of change
This change is