Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make the block pruning more clear #15079

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

BohuTANG
Copy link
Member

@BohuTANG BohuTANG commented Mar 23, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Make the block_pruning.rs more clear:

  1. internal_column_pruning
  2. inverted_index_pruning
  3. block_pruning[_sync]

This PR only for refactoring.

  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - (Exists Tests)

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

@BohuTANG BohuTANG requested a review from b41sh March 23, 2024 12:44
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Mar 23, 2024
@BohuTANG BohuTANG marked this pull request as ready for review March 23, 2024 13:09
@BohuTANG BohuTANG changed the title chore: make the block pruning more clear refactor(block pruning): make the block pruning more clear Mar 23, 2024
@BohuTANG BohuTANG changed the title refactor(block pruning): make the block pruning more clear refactor(block_pruning): make the block pruning more clear Mar 23, 2024
@BohuTANG BohuTANG changed the title refactor(block_pruning): make the block pruning more clear refactor: make the block pruning more clear Mar 23, 2024
@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Mar 23, 2024
@BohuTANG BohuTANG merged commit 707396d into databendlabs:main Mar 24, 2024
85 of 87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles. pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant