-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ast): fix incorrect display for ast (part 1) #15069
Conversation
May I ask how can we determine if the SQL generated by Display is equivalent to the original SQL? This has troubled me for a long time. |
An ideal display will satisfy two rules: 1. The display string contains all information in the original sql, despite of formatting difference; 2. Reparse the displayed string and then display it again should come out with the identical sql. In this PR, I'll add a check for the second rule. |
Thanks. The second rule is brilliant. |
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Briefly describe what this PR aims to solve. Include background context that will help reviewers understand the purpose of the PR.
Related #14904
Tests
Type of change