Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Use CrudMgr to impl ConnectionMgr #15003

Merged
merged 2 commits into from
Mar 19, 2024
Merged

refactor: Use CrudMgr to impl ConnectionMgr #15003

merged 2 commits into from
Mar 19, 2024

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Mar 19, 2024 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

refactor: Use CrudMgr to impl ConnectionMgr

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Refactoring

Related Issues

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Mar 19, 2024
@drmingdrmer drmingdrmer marked this pull request as ready for review March 19, 2024 01:59
@drmingdrmer drmingdrmer merged commit 98652d1 into databendlabs:main Mar 19, 2024
72 checks passed
@drmingdrmer drmingdrmer deleted the 45-conn-mgr branch March 19, 2024 03:07
This was referenced Jul 18, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youngsofun youngsofun youngsofun approved these changes

@everpcpc everpcpc Awaiting requested review from everpcpc

@lichuang lichuang Awaiting requested review from lichuang

Assignees
No one assigned
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define connection_mgr keys with kvapi::Key
2 participants
@drmingdrmer @youngsofun