-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support multi-table insert #15002
Conversation
3391b41
to
8c15684
Compare
# Conflicts: # src/query/ast/src/ast/statements/statement.rs # src/query/sql/src/executor/physical_plan.rs # src/query/storages/fuse/src/operations/common/mutation_log.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really enjoy reading this PR.
left some comments/suggestions, pls feel free to amend those in the subsequent PR (if necessary).
and for the 'next steps', it is also suggested to implement the VALUES (expr ..) first, since it currently seems to be the functionality most eagerly awaited by users.
tests/sqllogictests/suites/base/09_fuse_engine/090100_insert_multi_table.sql
Outdated
Show resolved
Hide resolved
src/query/service/src/interpreters/interpreter_insert_multi_table.rs
Outdated
Show resolved
Hide resolved
src/query/service/src/pipelines/builders/builder_insert_multi_table.rs
Outdated
Show resolved
Hide resolved
src/query/sql/src/executor/physical_plans/physical_multi_table_insert.rs
Outdated
Show resolved
Hide resolved
src/query/storages/fuse/src/operations/common/processors/multi_table_insert_commit.rs
Show resolved
Hide resolved
Co-authored-by: dantengsky <dantengsky@gmail.com>
This reverts commit 9a6aef1.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Syntax
Where:
Integrate with other features (Now)
Multi-table insert
loads data into multi table atomatically, and it can be used in a multi-stmt transaction.Next step
VALUES (<source_col_name>[ , ... ]
->VALUES ({expr | DEFAULT }[ , ... ]
, which supports eval different exprs for different branch.Tests
Type of change