Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: number range for settings #14985

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

BohuTANG
Copy link
Member

@BohuTANG BohuTANG commented Mar 17, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  • Add range for all Number settings
  • Improve some setting description
  • Add timezone(String) range
  • Fixes #[Link the issue here]

Tests

  • Unit Test(Exists Tests)
  • Logic Test(Exists Tests)
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Mar 17, 2024
@BohuTANG BohuTANG force-pushed the dev-settings-range branch from d1ac5f0 to 8933dc7 Compare March 17, 2024 14:04
@BohuTANG BohuTANG force-pushed the dev-settings-range branch from 4737816 to a0310bd Compare March 17, 2024 14:33
@BohuTANG BohuTANG force-pushed the dev-settings-range branch from 19643e4 to 3e688bb Compare March 17, 2024 15:15
@BohuTANG BohuTANG requested a review from zhang2014 March 18, 2024 01:14
@BohuTANG BohuTANG marked this pull request as ready for review March 18, 2024 01:14
@BohuTANG BohuTANG merged commit 19b1fd3 into databendlabs:main Mar 18, 2024
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants