-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a new ratio config instead of table_data_deserialized_data_bytes #14896
Conversation
Thanks for your contribution! There's a concern that hoping you can consider in this PR: In some scenarios (such as testing and deploying on cloud services), retaining the Furthermore, if both settings are non-zero, the Similar handling in the settings for spilling may serve as a reference (however, in the scenario of this PR, there's no need to consider settings at the per_core level). cc @BohuTANG |
@dantengsky Your suggestion looks great to me. |
Co-authored-by: dantengsky <dantengsky@gmail.com>
Co-authored-by: dantengsky <dantengsky@gmail.com>
@dantengsky, already made the original one back, and have dealt with the priority |
@chienguo LGTM & thanks |
@chienguo 👍 . Thanks for your contribution. |
@BohuTANG, @dantengsky, thanks for your help |
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
feat: add a new ratio config instead of table_data_deserialized_data_bytes #14866
Tests
Type of change
This change is