Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support function to_decimal(string). #10369

Merged
merged 12 commits into from
Mar 7, 2023
Merged

feat: support function to_decimal(string). #10369

merged 12 commits into from
Mar 7, 2023

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented Mar 6, 2023 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

the last pr of #2931
sorry for delay.

  • add some unit tests

Closes #2931

@vercel
Copy link

vercel bot commented Mar 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
databend ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2023 at 11:49PM (UTC)

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Mar 6, 2023
@youngsofun youngsofun mentioned this pull request Mar 6, 2023
Closed
17 tasks
@youngsofun youngsofun requested review from b41sh and ariesdevil March 6, 2023 06:48
sundy-li
sundy-li approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@sundy-li sundy-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest lgtm

@sundy-li
Copy link
Member

sundy-li commented Mar 6, 2023

You can modify CAST_FROM_STRING_RULES to have String to Decimal.

@youngsofun
Copy link
Member Author

You can modify CAST_FROM_STRING_RULES to have String to Decimal.

add String to Float too?

@sundy-li
Copy link
Member

sundy-li commented Mar 6, 2023

You can modify CAST_FROM_STRING_RULES to have String to Decimal.

add String to Float too?

ok

@youngsofun
Copy link
Member Author

https://github.com/datafuselabs/databend/actions/runs/4344883781/jobs/7588830162 ci failure not related to this pr

@youngsofun
Copy link
Member Author

this file only in cluster mode
https://github.com/datafuselabs/databend/actions/runs/4344883781/jobs/7589074001

Test finished, fail fast enabled, 1 out of 3369 records failed to run
0: query result mismatch:
[SQL] SELECT sum(c1),  sum(c2) FROM test;
[Diff] (-expected|+actual)
-   5050 0
+   NULL NULL
Error: SelfError("sqllogictest failed")
at tests/sqllogictests/suites/base/09_fuse_engine/09_0023_replace_into:195

@youngsofun youngsofun mentioned this pull request Mar 6, 2023
Closed
@BohuTANG BohuTANG mentioned this pull request Mar 6, 2023
Closed
@mergify mergify bot merged commit 17bb67c into databendlabs:main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li approved these changes

@b41sh b41sh b41sh approved these changes

@andylokandy andylokandy Awaiting requested review from andylokandy

@BohuTANG BohuTANG Awaiting requested review from BohuTANG

@ariesdevil ariesdevil Awaiting requested review from ariesdevil

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking: Support DataType::Decimal
3 participants
@youngsofun @sundy-li @b41sh