Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: load/unload decimal with CSV/TSV/NDJSON #10176

Merged
merged 5 commits into from
Feb 23, 2023
Merged

feat: load/unload decimal with CSV/TSV/NDJSON #10176

merged 5 commits into from
Feb 23, 2023

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented Feb 23, 2023 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  1. decimal encode to string in JSON.
  2. the tests change is simple, since the core parse-decimal logic is the same in values which has a lot of tests, but already make sure unloaded can be loaded and the content is the same
  3. small refactor and add some comments for field_encoder trait.

Closes #issue

@vercel
Copy link

vercel bot commented Feb 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
databend ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 23, 2023 at 5:37AM (UTC)

@youngsofun youngsofun changed the title feat:: load/unload decimal with CSV/TSV/NDJSON feat: load/unload decimal with CSV/TSV/NDJSON Feb 23, 2023
@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Feb 23, 2023
@youngsofun youngsofun mentioned this pull request Feb 23, 2023
Closed
17 tasks
@youngsofun youngsofun requested a review from sundy-li February 23, 2023 05:21
@BohuTANG BohuTANG merged commit e711057 into databendlabs:main Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li approved these changes

@BohuTANG BohuTANG BohuTANG approved these changes

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@youngsofun @BohuTANG @sundy-li