Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conflict between python2 and python3 when running locally #3689

Closed
yihong0618 opened this issue Dec 29, 2021 · 5 comments
Closed

Conflict between python2 and python3 when running locally #3689

yihong0618 opened this issue Dec 29, 2021 · 5 comments

Comments

@yihong0618
Copy link
Contributor

As pic shows.

When run locally it may pip as python3 and run as python2 and raise the import error

image

something like.
image
@yihong0618 yihong0618 mentioned this issue Dec 29, 2021
Merged
databend-bot added a commit that referenced this issue Dec 29, 2021
@databend-bot
Merge pull request #3690 from yihong0618/main
0ef869a 
[ci] Fix: perf maybe failed when run locally, issue #3689
@PsiACE
Copy link
Member

PsiACE commented Dec 29, 2021

closed by #3690

also, I don't think we would consider supporting Python2.

@PsiACE PsiACE closed this as completed Dec 29, 2021
@yihong0618
Copy link
Contributor Author

@PsiACE I think the code wait_tcp is running in Python2 do you want to make it to Python3?

@PsiACE
Copy link
Member

PsiACE commented Dec 29, 2021

@PsiACE I think the code wait_tcp is running in Python2 do you want to make it to Python3?

Certainly. It is well known that python2 is at the end of its life cycle.

@yihong0618
Copy link
Contributor Author

@PsiACE I think the code wait_tcp is running in Python2 do you want to make it to Python3?

Certainly. It is well known that python2 is at the end of its life cycle.

Cool, can I take a try?

@PsiACE
Copy link
Member

PsiACE commented Dec 29, 2021

Cool, can I take a try?

Thank you for your willingness to help, please feel free to submit a PR

@yihong0618 yihong0618 mentioned this issue Dec 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yihong0618 @PsiACE