Skip to content

Commit

Permalink
small refactor.
Browse files Browse the repository at this point in the history
  • Loading branch information
youngsofun committed Sep 25, 2024
1 parent 89d740d commit dd1ab6f
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,11 @@ use crate::servers::http::error::QueryError;
use crate::servers::http::middleware::EndpointKind;
use crate::servers::http::middleware::HTTPSessionMiddleware;
use crate::servers::http::middleware::MetricsMiddleware;
use crate::servers::http::v1::query::string_block::StringBlock;
use crate::servers::http::v1::query::Progresses;
use crate::servers::http::v1::HttpQueryContext;
use crate::servers::http::v1::HttpQueryManager;
use crate::servers::http::v1::HttpSessionConf;
use crate::servers::http::v1::StringBlock;
use crate::servers::HttpHandlerKind;
use crate::sessions::QueryAffect;

Expand Down
2 changes: 0 additions & 2 deletions src/query/service/src/servers/http/v1/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ mod http_query_handlers;
mod query;
mod session;
mod stage;
pub mod string_block;
mod suggestions;

pub use discovery::discovery_nodes;
Expand All @@ -42,7 +41,6 @@ pub use session::ClientSessionManager;
pub(crate) use session::SessionClaim;
pub use stage::upload_to_stage;
pub use stage::UploadToStageResponse;
pub(crate) use string_block::StringBlock;
pub use suggestions::list_suggestions;
pub use suggestions::SuggestionsResponse;

Expand Down
1 change: 1 addition & 0 deletions src/query/service/src/servers/http/v1/query/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ mod http_query_context;
mod http_query_manager;
mod page_manager;
pub mod sized_spsc;
pub mod string_block;

pub(crate) use execute_state::ExecuteState;
pub use execute_state::ExecuteStateKind;
Expand Down
4 changes: 2 additions & 2 deletions src/query/service/src/servers/http/v1/query/page_manager.rs
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ use log::debug;
use log::info;
use parking_lot::RwLock;

use super::string_block::block_to_strings;
use super::string_block::StringBlock;
use crate::servers::http::v1::query::sized_spsc::SizedChannelReceiver;
use crate::servers::http::v1::string_block::block_to_strings;
use crate::servers::http::v1::StringBlock;

#[derive(Debug, PartialEq, Eq)]
pub enum Wait {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

use std::sync::Arc;

use databend_common_exception::Result;
use databend_common_expression::Column;
use databend_common_expression::DataBlock;
Expand All @@ -25,8 +23,6 @@ pub struct StringBlock {
pub(crate) data: Vec<Vec<Option<String>>>,
}

pub type StringBlockRef = Arc<StringBlock>;

fn data_is_null(column: &Column, row_index: usize) -> bool {
match column {
Column::Null { .. } => true,
Expand Down

0 comments on commit dd1ab6f

Please sign in to comment.