Merge pull request #5990 from junnplus/role-statement

fix display for create/drop role statement
databendlabs · Jun 16, 2022 · 7de80ae · 7de80ae
2 parents 01483df + a7410e1
commit 7de80ae
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/common/ast/src/ast/statement.rs b/common/ast/src/ast/statement.rs
@@ -990,7 +990,7 @@ impl<'a> Display for Statement<'a> {
                 if *if_not_exists {
                     write!(f, " IF NOT EXISTS")?;
                 }
-                write!(f, " {role}")?;
+                write!(f, " '{role}'")?;
             }
             Statement::DropRole {
                 if_exists,
@@ -1000,7 +1000,7 @@ impl<'a> Display for Statement<'a> {
                 if *if_exists {
                     write!(f, " IF EXISTS")?;
                 }
-                write!(f, " {role}")?;
+                write!(f, " '{role}'")?;
             }
             Statement::CreateUDF {
                 if_not_exists,

diff --git a/common/ast/tests/it/testdata/statement.txt b/common/ast/tests/it/testdata/statement.txt
@@ -3153,7 +3153,7 @@ AlterUser {
 ---------- Input ----------
 create role 'test'
 ---------- Output ---------
-CREATE ROLE test
+CREATE ROLE 'test'
 ---------- AST ------------
 CreateRole {
     if_not_exists: false,
@@ -3164,7 +3164,7 @@ CreateRole {
 ---------- Input ----------
 drop role if exists 'test'
 ---------- Output ---------
-DROP ROLE IF EXISTS test
+DROP ROLE IF EXISTS 'test'
 ---------- AST ------------
 DropRole {
     if_exists: true,