-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete overhaul (separated Dockerfiles, Nuxt3, ...) #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ move start servers into index.js
- added back things that went missing during the migration - the docker-compose logs are now saved - reordered variables, imports, ... - specify the source of $fetch calls - fixed the default 8px margin, see https://www.joshwcomeau.com/css/custom-css-reset/ for more CSS hacks - tried to fix the emits, subject to change - VJSF migration not 100% done yet - probably fixed some ws bugs - moved sources/ to ui/assets/sources/ - removed every require left - ui/assets/format.js seems unused - ui build now deletes the right folder - fixed the middleware - fixed some event bus oversights - store update: added error(), changed the login (! this can be the source of some errors)
+ bug : /api/v1/runs never return 403 error + bug : processings tests doesn't work
+ add logs
- the middleware now works - fixed some migration issues - uses navigateTo instead of router.push - the error layout is now in ui/ - properly set the HEAD metadata - moved all filters in 1 file - _id.vue is now [id].vue - properly instantiate the store
…t, some fixes in the store
- fix some eslint errors - create a gitignore for ui - better nuxt.config.js
… nuxt3 # Veuillez entrer un message de validation pour expliquer en quoi cette fusion est # nécessaire, surtout si cela fusionne une branche amont mise à jour dans une branche de sujet. # # Les lignes commençant par '#' seront ignorées, et un message vide # abandonne la validation.
albanm
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request is a complete change of how
processings
workHere's a comprehensive list of everything that have changed :
Global changes
server
toapi
andpublic
toui
to reflect the deliverables spliti
to do a clean install of the dependencies,build-types
to create the types from the schema.json,dev-zellij
to run the docker compose and all parts of processings in a nice UI,test-images
to run the project with the 3 Dockerfiles built, ...)@data-fair/lib
when possible8080
, data-fair on8081
and notify on8088
)node:test
instead ofmocha
api
8082
showAll
onGET /plugins-registry
, allowing to fetch distTags only on demand (useful for displaying test versions of plugins). This allows the request to be blazingly fast by defaultGET /processings
, which uses Mongo's facets :plugins
: Allows to filter the processings by plugin usedstatuses
: Allows to filter the processings by status (last run status and next run if any)GET /plugins
returns a new object along count and results :facets
, which is a object containingusages
:ui
sd-vue
components/admin
=>/admin/plugins
)worker