Refactor #97
Merged
Refactor #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Install ruff with autofix, list hook at the top. Port settings from flake8 to ruff.
…ammatically. The version for the documentation build was hard-coded in . It is now determined programmtically.
Prettifying the version isn't necessary when a tag is assigned correctly.
ThomasMarwitzQC
force-pushed
the
refactor
branch
from
d600c70 to
ce53708
Compare
|
Added ruff formatter @xhochy |
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
xhochy
requested changes
Nov 6, 2023
.pre-commit-config.yaml
Outdated
| - repo: https://github.com/Quantco/pre-commit-mirrors-black | ||
| rev: 23.7.0 | ||
| # Run ruff first because autofix behaviour is enabled | ||
| - repo: https://github.com/astral-sh/ruff-pre-commit |
There was a problem hiding this comment.
Please use the QuantCo-provided conda-based version of this.
xhochy
reviewed
Nov 6, 2023
.pre-commit-config.yaml
Outdated
Comment on lines
7
to
9
| - repo: https://github.com/Quantco/pre-commit-mirrors-ruff | ||
| rev: "0.1.3" | ||
| hooks: |
There was a problem hiding this comment.
Can we have a single ruff section?
Suggested change
| - repo: https://github.com/Quantco/pre-commit-mirrors-ruff | |
| rev: "0.1.3" | |
| hooks: |
xhochy
approved these changes
Nov 6, 2023
ThomasMarwitzQC
requested review from
siboehm,
mlondschien and
fjetter
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring changes include:
setup.cfgandsetup.pyintopyproject.tomldocs/conf.py#44 (as it relates to the refactoring)google_authstep.1.8.2