Add option to disable SSL verification for S3Store #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janjagusch
requested review from
siboehm,
mlondschien,
xhochy and
fjetter
as code owners
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 32 32
Lines 1986 1988 +2
=====================================
- Misses 1986 1988 +2
☔ View full report in Codecov by Sentry. |
xhochy
reviewed
Jul 24, 2023
| @@ -7,7 +7,7 @@ | |||
|
|
|||
| storage = pytest.importorskip("google.cloud.storage") | |||
|
|
|||
| S3_URL = "s3://minio:miniostorage@127.0.0.1:9000/bucketname?create_if_missing=true&is_secure=false" | |||
| S3_URL = "s3://minio:miniostorage@127.0.0.1:9000/bucketname?create_if_missing=true&is_secure=false&verify=False" | |||
There was a problem hiding this comment.
No particular reason. It makes no difference, but I've lowercawed it for consistency.
xhochy
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not always possible (or, at least, not convenient) to deal with SSL verification when the certificates are self-signed. This PR adds an option to disable SSL verification.
Depends on #81.
Checklist
docs/changes.rstentry