Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor store creation from URL #71

Merged

Conversation

simonbohnen
Copy link
Contributor

@simonbohnen simonbohnen commented Nov 7, 2022

Sorry for the larger PR! This refactoring cleans up how stores are created from URLs.

  • Move store creation from URL or parameters to the individual stores
  • Deprecated old store creation methods
Stores

  • Boto3Store, BotoStore, S3FSStore
    • from_url
    • from_parsed_url
    • Test against old implementation
  • GoogleCloudStore
    • from_url
    • from_parsed_url
    • Test against old implementation
  • AzureBlockBlobStore
    • from_url
    • from_parsed_url
    • Test against old implementation
  • RedisStore
    • from_url
    • from_parsed_url
    • Test against old implementation
  • DictStore
    • from_url
    • from_parsed_url
    • Test against old implementation
  • FilesystemStore
    • from_url
    • from_parsed_url
    • Test against old implementation

Checklist

  • Added a docs/changes.rst entry

@simonbohnen simonbohnen mentioned this pull request Nov 7, 2022
1 task
@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Base: 0.00% // Head: 0.00% // No change to project coverage 👍

Coverage data is based on head (ec3e27f) compared to base (d3bcfd2).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head ec3e27f differs from pull request most recent head a3702cb. Consider uploading reports for the commit a3702cb to get more accurate results

Additional details and impacted files
@@          Coverage Diff           @@
##            main     #71    +/-   ##
======================================
  Coverage   0.00%   0.00%            
======================================
  Files         30      32     +2     
  Lines       1859    2109   +250     
======================================
- Misses      1859    2109   +250     
Impacted Files Coverage Δ
minimalkv/__init__.py 0.00% <0.00%> (ø)
minimalkv/_boto.py 0.00% <0.00%> (ø)
minimalkv/_get_store.py 0.00% <0.00%> (ø)
minimalkv/_hstores.py 0.00% <0.00%> (ø)
minimalkv/_key_value_store.py 0.00% <0.00%> (ø)
minimalkv/_old_store_creation.py 0.00% <0.00%> (ø)
minimalkv/_old_urls.py 0.00% <0.00%> (ø)
minimalkv/fs.py 0.00% <0.00%> (ø)
minimalkv/fsspecstore.py 0.00% <0.00%> (ø)
minimalkv/memory/__init__.py 0.00% <0.00%> (ø)
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@simonbohnen simonbohnen marked this pull request as ready for review January 19, 2023 10:58
@xhochy
Copy link
Member

xhochy commented Jan 19, 2023

Can you please split this into smaller PRs? This large one is hard to review and it looks like the changes to the individual stores can be done separately.

@simonbohnen simonbohnen marked this pull request as draft January 19, 2023 16:04
@simonbohnen simonbohnen mentioned this pull request Jan 19, 2023
1 task
@xhochy xhochy merged commit a3702cb into data-engineering-collective:main Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants