Changing generic IO type to BinaryIO.
#100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanols
requested review from
siboehm,
mlondschien,
xhochy and
fjetter
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 32 32
Lines 1993 1993
=====================================
Misses 1993 1993 ☔ View full report in Codecov by Sentry. |
|
@fhoehle @janjagusch Can one of you have a look at this? |
johanols
force-pushed
the
changing-io-typing
branch
from
67ad6a1 to
75443d3
Compare
Since virtually every implementation expects the underlying data type of the file-like object to be bytes, it is more appropriate to use `BinaryIO` in favor of the broader `IO` type.
xhochy
force-pushed
the
changing-io-typing
branch
from
75443d3 to
7f105ef
Compare
xhochy
approved these changes
Nov 28, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since virtually every implementation expects the underlying data type of the file-like object to be bytes, it is more appropriate to use
BinaryIOin favor of the broaderIOtype.Checklist
docs/changes.rstentry