Make tests independent of implementation #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmyachev
force-pushed
the
tests-impl-agnostic
branch
2 times, most recently
from
e9645c9
to
0b080a4
Compare
anmyachev
force-pushed
the
tests-impl-agnostic
branch
from
0b080a4
to
d92c889
Compare
anmyachev
commented
Apr 22, 2024
Comment on lines
+33
to
+35
| pytest tests --cov=dataframe_api_compat/pandas_standard --cov=tests --cov-append --cov-fail-under=50 --cov-report= --library pandas-numpy | ||
| pytest tests --cov=dataframe_api_compat/pandas_standard --cov=tests --cov-append --cov-fail-under=50 --cov-report= --library pandas-nullable | ||
| pytest tests --cov=dataframe_api_compat/polars_standard --cov=tests --cov-append --cov-fail-under=100 --library polars-lazy |
There was a problem hiding this comment.
A more scalable way to run tests. Not all dependencies can be installed in one environment and in the future we will have to use different environments for different implementations.
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds new entities to test utilities that allow us to hide library details from tests:
BaseHandler,PandasHandlerandPolarsHandler.Similar idea: https://github.com/data-apis/dataframe-interchange-tests?tab=readme-ov-file#what-the-heck-is-libraryinfo
It also adds a new
--libraryparameter for pytest to be able to run tests for separate implementation.