Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove (migrated) DLPack docs from Data Interchange page #396

Merged
merged 3 commits into from
Feb 25, 2022

Conversation

tirthasheshpatel
Copy link
Contributor

DLPack now has official docs published at: https://dmlc.github.io/dlpack/latest/

dmlc/dlpack#93 migrated the docs added in #106 under the Python Specification of DLPack page. So, these aren't needed anymore. This PR removed the migrated docs and redirects to DLPack's official doc pages.

Copy link
Contributor

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte
Copy link
Contributor

kgryte commented Feb 24, 2022

Thanks for reviewing @leofang!

@kgryte kgryte added the Narrative Content Narrative documentation content. label Feb 24, 2022
@kgryte kgryte added this to the v2021 milestone Feb 24, 2022
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too. Thanks @tirthasheshpatel & reviewers!

@rgommers rgommers merged commit cc47332 into data-apis:main Feb 25, 2022
@tirthasheshpatel tirthasheshpatel deleted the remove-dlpack-docs branch February 25, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Narrative Content Narrative documentation content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants