-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update "scope of array API" and DLPack structure diagrams #326
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before merging this PR, we should ask @tqchen to make a new DLPack release to include the oneAPI support.
btw @rgommers I think DLDeviceType needs to be updated. For example, GPU is renamed to CUDA. Here's a complete list:
I believe the diagram removes the |
@rgommers I believe this PR still needs a couple of changes to the diagrams. Are we still waiting on DLPack to move this forward? |
2c53e37
to
5228eff
Compare
Thanks Leo, updated now - also including WebGPU and Hexagon which are new. In addition to removing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @leofang?
Thanks, @leofang! |
Yes, @tirthasheshpatel is already working on this. |
I have created a PR on DLPack migrating the content here: dmlc/dlpack#93. Feedback welcome! |
Just bringing these in line with changes in the content over the past months.