Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "scope of array API" and DLPack structure diagrams #326

Merged
merged 2 commits into from
Feb 8, 2022

Conversation

rgommers
Copy link
Member

@rgommers rgommers commented Nov 9, 2021

Just bringing these in line with changes in the content over the past months.

@rgommers rgommers added the Maintenance Bug fix, typo fix, or general maintenance. label Nov 9, 2021
Copy link
Contributor

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging this PR, we should ask @tqchen to make a new DLPack release to include the oneAPI support.

@leofang leofang added this to the v2021 milestone Nov 9, 2021
@leofang
Copy link
Contributor

leofang commented Nov 9, 2021

btw @rgommers I think DLDeviceType needs to be updated. For example, GPU is renamed to CUDA. Here's a complete list:

  kDLCPU = 1,
  kDLCUDA = 2,
  kDLCUDAHost = 3,
  kDLOpenCL = 4,
  kDLVulkan = 7,
  kDLMetal = 8,
  kDLVPI = 9,
  kDLROCM = 10,
  kDLROCMHost = 11,
  kDLCUDAManaged = 13,
  kDLOneAPI = 14,

I believe the diagram removes the kDL prefix, but otherwise all these should be listed.

@kgryte
Copy link
Contributor

kgryte commented Jan 5, 2022

@rgommers I believe this PR still needs a couple of changes to the diagrams. Are we still waiting on DLPack to move this forward?

@rgommers
Copy link
Member Author

rgommers commented Feb 8, 2022

I believe the diagram removes the kDL prefix, but otherwise all these should be listed.

Thanks Leo, updated now - also including WebGPU and Hexagon which are new. In addition to removing kDL, I also made names more human-readable, for example Verilog instead of VPI. I don't think sticking to names used in code is very useful in some cases.

Copy link
Contributor

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @leofang?

@leofang leofang merged commit 2b9c402 into data-apis:main Feb 8, 2022
@kgryte
Copy link
Contributor

kgryte commented Feb 8, 2022

Thanks, @leofang!

@leofang
Copy link
Contributor

leofang commented Feb 8, 2022

Thanks, @rgommers! Follow-up question for you both @rgommers @kgryte: Would it be better to move the DLPack page to the DLPack website (including the diagram updated here), or would we prefer to keep a separate copy?

@rgommers rgommers deleted the update-diagrams branch February 9, 2022 08:54
@rgommers
Copy link
Member Author

rgommers commented Feb 9, 2022

Thanks, @rgommers! Follow-up question for you both @rgommers @kgryte: Would it be better to move the DLPack page to the DLPack website (including the diagram updated here), or would we prefer to keep a separate copy?

Yes, @tirthasheshpatel is already working on this.

@tirthasheshpatel
Copy link
Contributor

I have created a PR on DLPack migrating the content here: dmlc/dlpack#93. Feedback welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Bug fix, typo fix, or general maintenance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants