Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_jupyter.py::test_shutsdown_cleanly #8954

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

hendrikmakait
Copy link
Member

Upstream: jupyterlab/jupyterlab#17012

  • Tests added / passed
  • Passes pre-commit run --all-files

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hendrikmakait hendrikmakait marked this pull request as ready for review December 2, 2024 16:17
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    29 files  ±0      29 suites  ±0   12h 30m 21s ⏱️ + 13m 22s
 4 130 tests ±0   4 017 ✅ +1    111 💤 ±0  2 ❌  - 1 
55 839 runs  ±0  53 408 ✅ +6  2 427 💤 ±0  4 ❌  - 6 

For more details on these failures, see this check.

Results for commit 9b878f9. ± Comparison against base commit 8b6623d.

@hendrikmakait hendrikmakait merged commit 5e0ea69 into dask:main Dec 2, 2024
29 of 34 checks passed
@hendrikmakait hendrikmakait deleted the fix-test_shutsdown_cleanly branch December 2, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants