Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal cleanup of P2P code #8907

Merged
merged 7 commits into from
Oct 25, 2024

Conversation

hendrikmakait
Copy link
Member

This PR cleans up responsibilities and import hierarchies by moving some code around.

  • Tests added / passed
  • Passes pre-commit run --all-files

Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    25 files  ±0      25 suites  ±0   10h 23m 22s ⏱️ + 2m 19s
 4 123 tests ±0   4 008 ✅ +2    110 💤 ±0  5 ❌  - 2 
47 622 runs  ±0  45 527 ✅ ±0  2 089 💤 +2  6 ❌  - 2 

For more details on these failures, see this check.

Results for commit db0e7a3. ± Comparison against base commit 928d770.

Copy link
Member

@fjetter fjetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming CI is green-ish

continuous_integration/environment-3.10.yaml Outdated Show resolved Hide resolved
This reverts commit 94eb592.
@hendrikmakait hendrikmakait merged commit aad1178 into dask:main Oct 25, 2024
10 of 29 checks passed
@hendrikmakait hendrikmakait deleted the migrate-p2p-barrier branch October 25, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants