Fix doc build #8892
Merged
Fix doc build #8892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
still failing. FWIW I'm also fine with nuking the in-comment typing. We have type annotations and they are also rendered in sphinx. We don't have a consistent style guideline for this |
|
I've just removed it for now to get doc build passing
…On Tue, Oct 15, 2024 at 12:25 PM Florian Jetter ***@***.***> wrote:
still failing. FWIW I'm also fine with nuking the in-comment typing. We
have type annotations and they are also rendered in sphinx. We don't have a
consistent style guideline for this
—
Reply to this email directly, view it on GitHub
<#8892 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOYQZGEGK5IIXP6EFLE2YQLZ3TUPZAVCNFSM6AAAAABP6YAOSCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJTGQ4TQMZQHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I actually think that the type hint is the problem :( |
This reverts commit 8d69b28.
|
We actually have 2 WorkerState classes, which is something that confuses Spinx. I clarified the import now, so things are good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #xxxx
pre-commit run --all-files