-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PipInstall plugin on Worker #8839
Fix PipInstall plugin on Worker #8839
Conversation
response = { # type: ignore[unreachable] | ||
k: deserialize(v.header, v.frames) | ||
for k, v in response.items() | ||
if isinstance(v, Serialized) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nasty, am I missing a better way? cc @fjetter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really know this code section very well but my first gut reaction is: No, this is it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect this is an artifact of https://github.com/dask/distributed/blob/f5c30e852b32acd2834f2cf5319bc8cab8556e6a/distributed/client.py#L5138C20-L5138C32
this explicit dumps shouldn't be necessary and I suppose this is why you get some Serialized
objects here but IDK for sure
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 25 files ± 0 25 suites ±0 10h 21m 7s ⏱️ + 9m 12s For more details on these failures, see this check. Results for commit 73ce609. ± Comparison against base commit fe79a36. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dumps thing can move in another PR if this is somethign we want to pursue
Closes #8838
pre-commit run --all-files