Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PipInstall plugin on Worker #8839

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

hendrikmakait
Copy link
Member

Closes #8838

  • Tests added / passed
  • Passes pre-commit run --all-files

Comment on lines +474 to +478
response = { # type: ignore[unreachable]
k: deserialize(v.header, v.frames)
for k, v in response.items()
if isinstance(v, Serialized)
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nasty, am I missing a better way? cc @fjetter

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really know this code section very well but my first gut reaction is: No, this is it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this is an artifact of https://github.com/dask/distributed/blob/f5c30e852b32acd2834f2cf5319bc8cab8556e6a/distributed/client.py#L5138C20-L5138C32

this explicit dumps shouldn't be necessary and I suppose this is why you get some Serialized objects here but IDK for sure

Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    25 files  ± 0      25 suites  ±0   10h 21m 7s ⏱️ + 9m 12s
 4 103 tests + 2   3 986 ✅ + 3    113 💤 ±0  4 ❌  - 1 
47 414 runs  +24  45 279 ✅ +25  2 130 💤  - 1  5 ❌ ±0 

For more details on these failures, see this check.

Results for commit 73ce609. ± Comparison against base commit fe79a36.

Copy link
Member

@fjetter fjetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dumps thing can move in another PR if this is somethign we want to pursue

@hendrikmakait hendrikmakait merged commit 30e01fb into dask:main Aug 20, 2024
26 of 33 checks passed
@hendrikmakait hendrikmakait deleted the fix-pipinstall-on-workers branch August 20, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PipInstall plugin - TypeError: Semaphore.__init__() got an unexpected keyword argument 'register'
2 participants